git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] git-compat-util: add a test balloon for C99 supporty

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 23, 2021, 12:32 UTC
Message-ID
<nycvar.QRO.7.76.6.2111231331530.63@tvgsbejvaqbjf.bet>
In-Reply-To
<xmqqwnkzdepm.fsf@gitster.g>
Hi Junio,
On Mon, 22 Nov 2021, Junio C Hamano wrote:
Show 16 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >> But if we were to do so, perhaps we'd want something like what I
> >> gave at https://lore.kernel.org/git/xmqqy25lwa86.fsf@gitster.g/ in
> >> its place to avoid confusing people.
> >
> > That sounds like a good course of action to me.
> >
> > Please note that the MSVC-related adjustment of the `FLEX_ARRAY` block is
> > still needed, I think.
>
> The "something like what I gave ... to avoid confusing people" patch
> is following up on the direction to drop the patch with -std=gnu99
> change.  IIRC, your MSVC adjustment was to tweak that patch we were
> discussing of dropping, so even if it is still needed, it won't be
> part of what I was doing.

I thought we were only dropping the `--std=gnu99` part, not the change to the `git-compat-util.h` header file, nor the patch to the CMake configuration for MS Visual C.

Ciao, Dscho

Previous: Carlo ArenasNext: Junio C Hamano
Message 12 of 14 in “Re: [PATCH 1/1] git-compat-util: add a test balloon for C99 support”
  1. Johannes SchindelinNov 16, 2021
  2. Junio C HamanoNov 17, 2021
  3. Johannes SchindelinNov 22, 2021
  4. Ævar Arnfjörð BjarmasonNov 22, 2021
  5. Junio C HamanoNov 22, 2021
  6. Carlo ArenasNov 22, 2021
  7. Junio C HamanoNov 22, 2021
  8. Junio C HamanoNov 22, 2021
  9. Johannes SchindelinNov 22, 2021
  10. Junio C HamanoNov 22, 2021
  11. Carlo ArenasNov 22, 2021
  12. Johannes SchindelinNov 23, 2021
  13. Junio C HamanoNov 23, 2021
  14. brian m. carlsonNov 24, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.