Re: Error in 'git clone' via SSH in v2.33.0 (related to commit ae1a7ee)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 22, 2021, 15:29 UTC
Message-ID: <nycvar.QRO.7.76.6.2110221723430.62@tvgsbejvaqbjf.bet>
In-Reply-To: <CAN2Gq0de1tpiLNcQqoZmgAu=kuOXxEmAtziWM7OJtGPGhLneYQ@mail.gmail.com>

Hi,

[Cc:ing Peff as the author of the commit identified as the culprit]

On Fri, 22 Oct 2021, Philipp Eib wrote:

Show 9 quoted lines

> Hi,
>
> Using git-for-windows, I noticed that an SSH git clone of an internal
> repo broke for me in git v2.33.0
> The exact error is:
>
> fetch-pack: unexpected disconnect while reading sideband packet/s
> fatal: early EOF
> fatal: fetch-pack: invalid index-pack

It might be important to note that this is using SSH.

Show 7 quoted lines

>
> Cloning via HTTPS continued to work.
> It was also repository-specific as cloning other repositories from the
> same (Gitlab) instance via SSH was working fine.
>
> Together with the maintainer we traced the problem back to git commit
> ae1a7ee (https://github.com/git/git/commit/ae1a7eefffe60425e6bf6a2065e042ae051cfb6c).

The `--pretty=reference` format: ae1a7eefffe6 (fetch-pack: signal v2 server that we are done making requests, 2021-05-19). The idea of this patch is apparently to "do a half-duplex shutdown to indicate that they can hang up as soon as the pack is sent".

Peff, any ideas what could go wrong here?

Thanks, Dscho

Show 11 quoted lines

> Reverting this commit and rebuilding fixed the issue within git-for-windows.
> (You can read the full conversation here:
> https://github.com/git-for-windows/git/issues/3444)
>
> Unfortunately I cannot give a reproducible example as the internal
> repository cannot be shared.
> I have also not tested on linux.
>
> Regards,
> Philipp
>