git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] A pair of git am --abort issues

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Sep 13, 2021, 12:08 UTC
Message-ID
<nycvar.QRO.7.76.6.2109131408030.55@tvgsbejvaqbjf.bet>
In-Reply-To
<pull.1087.v2.git.git.1631269876.gitgitgadget@gmail.com>
Hi Elijah,
On Fri, 10 Sep 2021, Elijah Newren via GitGitGadget wrote:
Show 17 quoted lines
> This series documents a few issues with git am --abort in the form of new
> testcases, and fixes one of them. However, while I was surprised the abort
> left the working directory dirty, I couldn't find any documentation to
> confirm it should or shouldn't be, and reading the code led me to question
> if perhaps it was intentional. Anyway, if it's intended, let me know and
> I'll drop that testcase.
>
> For frame of reference, these were some issues I found while working on
> unintentional removal of untracked files/directories and the current working
> directory, and I'm just submitting them separately.
>
> Changes since v1:
>
>  * Added a patch to tweak the documentation to clarify that partial cleaning
>    of worktree is expected with --abort
>  * Tweaked the second test to be a test that unrelated dirty files are kept,
>    as suggested by Junio
FWIW I gave this a light read-over and am happy with it!

Ciao, Dscho

Previous: Elijah Newren via GitGitGadget
Message 15 of 15 in “A pair of git am --abort issues”
  1. 0/2 A pair of git am --abort issuesElijah Newren via GitGitGadget, Sep 8, 2021
  2. 1/2 t4151: document a pair of am --abort bugsElijah Newren via GitGitGadget, Sep 8, 2021
  3. Bagas SanjayaSep 8, 2021
  4. Elijah NewrenSep 8, 2021
  5. Junio C HamanoSep 8, 2021
  6. Elijah NewrenSep 8, 2021
  7. Junio C HamanoSep 8, 2021
  8. 2/2 am: fix incorrect exit status on am fail to abortElijah Newren via GitGitGadget, Sep 8, 2021
  9. Junio C HamanoSep 8, 2021
  10. Johannes SchindelinSep 8, 2021
  11. 0/3 A pair of git am --abort issuesElijah Newren via GitGitGadget, Sep 10, 2021
  12. 1/3 git-am.txt: clarify --abort behaviorElijah Newren via GitGitGadget, Sep 10, 2021
  13. 2/3 t4151: add a few am --abort testsElijah Newren via GitGitGadget, Sep 10, 2021
  14. 3/3 am: fix incorrect exit status on am fail to abortElijah Newren via GitGitGadget, Sep 10, 2021
  15. Johannes SchindelinSep 13, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.