Re: [PATCH] test-tool run-command: remove dead "testsuite" code

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 9, 2021, 11:26 UTC
Message-ID: <nycvar.QRO.7.76.6.2109091323150.59@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqtuiw9loh.fsf@gitster.g>

Hi Junio,

On Tue, 7 Sep 2021, Junio C Hamano wrote:

Show 14 quoted lines

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
> > Remove the "test-tool run-command testsuite" sub-sub-command, it has
> > not been used since 4c2c38e800f (ci: modification of main.yml to use
> > cmake for vs-build job, 2020-06-26), see also the earlier
> > 6081d3898fe (ci: retire the Azure Pipelines definition, 2020-04-11)
> > for another phasing out of the command.
>
> I'll leave this patch hanging in the list archive until I hear from
> somebody from Azure camp say that they do not need it anymore and
> they do not plan to use it in the future.  Of course, if somebody
> else from outside the Windows circle is using it or plans to use it
> in a near future, they can raise their voice heard while we are
> waiting for such an Ack.

As I mentioned, I would love for this to stay.

The reason is that there is a long-running ticket about polishing BusyBox-w32, polishing Git for Windows' support for BusyBox, and then shipping a MinGit [*1*] version _without_ Bash and _without_ Perl. Obviously, I would want to verify that it works as intended, and that's where this `testsuite` command would come in (we already bundle the test artifacts in our CI runs, so `test-tool.exe` would be available).

Ciao, Dscho

Footnote *1*: MinGit is a subset of Git for Windows, intended to be bundled by 3rd-party applications that do not require interactive Git usage, optimized for a small disk foot print. For more details, see https://github.com/git-for-windows/git/wiki/MinGit