Re: [PATCH] gc: remove unused launchctl_get_uid() call

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 9, 2021, 10:24 UTC
Message-ID: <nycvar.QRO.7.76.6.2109091222260.59@tvgsbejvaqbjf.bet>
In-Reply-To: <patch-1.1-93adb856b0c-20210909T012244Z-avarab@gmail.com>

Hi Ævar,

On Thu, 9 Sep 2021, Ævar Arnfjörð Bjarmason wrote:

Show 10 quoted lines

> When the launchctl_boot_plist() function was added in
> a16eb6b1ff3 (maintenance: skip bootout/bootstrap when plist is
> registered, 2021-08-24), an unused call to launchctl_get_uid() was
> added along with it. That call appears to have been copy/pasted from
> launchctl_boot_plist().
>
> Since we can remove that, we can also get rid of the "result"
> variable, whose only purpose was allow for the free() between its
> assignment and the return. That pattern also appears to have been
> copy/pasted from launchctl_boot_plist().

I don't find the most crucial information in that commit message: what is the fall-out of the removal of this call?

Such an analysis (_with_ a summary of it in the commit message) is definitely required. And it should not be left as an exercise for the reader.

Ciao, Johannes