Re: [PATCH] make: add install-strip target

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 17, 2021, 21:28 UTC
Message-ID: <nycvar.QRO.7.76.6.2108172327290.55@tvgsbejvaqbjf.bet>
In-Reply-To: <20210817110728.55842-1-bagasdotme@gmail.com>

Hi Bagas,

On Tue, 17 Aug 2021, Bagas Sanjaya wrote:

Show 9 quoted lines

> diff --git a/Makefile b/Makefile
> index 9573190f1d..8c4633ba8e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3093,6 +3093,9 @@ endif
>  	done && \
>  	./check_bindir "z$$bindir" "z$$execdir" "$$bindir/git-add$X"
>
> +install-strip: all strip

Would those `all` and `strip` targets interfere with one another if `make -j2` was called? If not, wouldn't it be sufficient to let `install-strip` depend on `strip` alone?

Ciao, Dscho

Show 20 quoted lines

> +	$(MAKE) install
> +
>  .PHONY: install-gitweb install-doc install-man install-man-perl install-html install-info install-pdf
>  .PHONY: quick-install-doc quick-install-man quick-install-html
>  install-gitweb:
> @@ -3265,7 +3268,7 @@ ifdef MSVC
>  	$(RM) compat/vcbuild/MSVC-DEFS-GEN
>  endif
>
> -.PHONY: all install profile-clean cocciclean clean strip
> +.PHONY: all install install-strip profile-clean cocciclean clean strip
>  .PHONY: shell_compatibility_test please_set_SHELL_PATH_to_a_more_modern_shell
>  .PHONY: FORCE cscope
>
>
> base-commit: 225bc32a989d7a22fa6addafd4ce7dcd04675dbf
> --
> 2.25.1
>
>