Re: [PATCH] ci: do not cancel all jobs of a matrix if one fails
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 28, 2021, 16:13 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2101281712460.54@tvgsbejvaqbjf.bet>
- In-Reply-To
- <YBJbJOLyh+ksolVB@coredump.intra.peff.net>
Hi,
On Thu, 28 Jan 2021, Jeff King wrote:
Show 17 quoted lines
> On Thu, Jan 28, 2021 at 04:06:08AM +0000, Philippe Blain via GitGitGadget wrote: > > > From: Philippe Blain <levraiphilippeblain@gmail.com> > > > > The CI/PR GitHub Actions workflow uses the 'matrix' strategy for the > > "windows-test", "vs-test", "regular" and "dockerized" jobs. The default > > behaviour of GitHub Actions is to cancel all in-progress jobs in a > > matrix if one of the job of the matrix fails [1]. > > > > This is not ideal as a failure early in a job, like during installation of > > the build/test dependencies on a specific platform, leads to the > > cancellation of all other jobs in the matrix. > > > > Set the 'fail-fast' variable to 'false' for all four matrix jobs in the > > workflow. > > I think this is worth doing.
Me, too. ACK!
Thanks, Dscho