git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Patchwork instance "Submitter" attribution and GitGitGadget

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 8, 2021, 15:07 UTC
Message-ID
<nycvar.QRO.7.76.6.2101081604470.2213@tvgsbejvaqbjf.bet>
In-Reply-To
<20210107223755.6fg77xjdbqiscwb2@chatter.i7.local>
Hi Konst,
On Thu, 7 Jan 2021, Konstantin Ryabitsev wrote:
Show 12 quoted lines
> On Thu, Jan 07, 2021 at 03:35:54PM +0100, Johannes Schindelin wrote:
> > > Would it help to use the "Sender:" header?  IIUC right now GGG
> > > records its name on "From:" with its e-mail and a human-readable
> > > name derived from the author of the ptach, but if it can record the
> > > true author on "From:" and leave GGG's name on the "Sender:", would
> > > patchwork use the "From:" side of the identity instead?
> >
> > To tie up that loose end: GMail seemed to insist in my tests on replacing
> > the `From:` header, therefore we cannot implement this `Sender:` idea, not
> > using GMail to deliver the GitGitGadget patch series at least.
>
> Can you possibly set X-Original-From: in the header?

Potentially. But unfortunately, I am too short on time to perform such experiments right now. And it is always subject to the question what GMail does with this header in the future. `Sender:` used to work IIRC, but now it doesn't.

Show 14 quoted lines
> Patchwork almost does the right thing with it, though right now it
> expects that the From: will be set to the list's email address (which is
> only correct for google groups).
>
> We have a workaround for the current situation on patchwork.kernel.org [1],
> but it requires parsing the body of the message instead of just relying on the
> headers.
>
> > > If that works, it would have an additional benefit of not having to
> > > add the in-body "From:" to override the mail-header "From:", to avoid
> > > attributing the authorship to GGG.
>
> Using the in-body From: is both good and proper for such service. Trying to
> put the author's email into the actual From will run afoul of SPF.
Indeed.

Therefore, I would prefer to keep doing that in GitGitGadget: send from its regular email address, and add the contributor's info in-body.

Ciao, Johannes

Show 5 quoted lines
>
> -K
>
> [1] https://git.kernel.org/pub/scm/infra/patchwork/procmail.git/tree/git.rc
>
Previous: Konstantin Ryabitsev
Message 6 of 6 in “Patchwork instance "Submitter" attribution and GitGitGadget”
  1. Philippe BlainJan 18, 2020
  2. Johannes SchindelinJan 20, 2020
  3. Junio C HamanoJan 21, 2020
  4. Johannes SchindelinJan 7, 2021
  5. Konstantin RyabitsevJan 7, 2021
  6. Johannes SchindelinJan 8, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.