Re: [PATCH] cmake: determine list of extra built-ins dynamically

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 4, 2020, 22:44 UTC
Message-ID: <nycvar.QRO.7.76.6.2012042341270.25979@tvgsbejvaqbjf.bet>
In-Reply-To: <X8qmClPjwYWIoExP@coredump.intra.peff.net>

Hi Peff,

On Fri, 4 Dec 2020, Jeff King wrote:

Show 9 quoted lines

> On Fri, Dec 04, 2020 at 07:33:56PM +0000, Johannes Schindelin via GitGitGadget wrote:
>
> > Rather than always play catch-up and adjust `git_builtin_extra`
> > manually, use the `BUILT_INS` definitions in the Makefile as
> > authoritative source and generate `git_builtin_extra` dynamically.
>
> Yay. This is exactly how I'd hoped things would work or the cmake file
> in general. I don't mind following micro-formats within our Makefile to
> keep things easier for the cmake parsing side.

Me, too. I am somewhat embarrassed that I missed the `git_builtin_extra` list in my review of the CMake patch series...

Show 5 quoted lines

> >  contrib/buildsystems/CMakeLists.txt | 15 +++++++++++----
> >  1 file changed, 11 insertions(+), 4 deletions(-)
>
> The implementation looks plausibly correct to me (bearing in mind that
> I've never written cmake).

It is a close copy of the two macros we already use to parse the `Makefile` for lists of `.o` files and for scripts.

Together with the fact that this patch fixes the CI build of Git for Windows' `shears/seen` branch (which is a continuously-rebased version of Git for Windows' `main` branch onto `seen`, plus fixups), I am fairly confident that it is correct.

Ciao, Dscho