Re: [PATCH v2 4/4] hook: add --porcelain to list command
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 24, 2020, 23:00 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2005250053080.56@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20200521185414.43760-5-emilyshaffer@google.com>
Hi Emily,
On Thu, 21 May 2020, Emily Shaffer wrote:
Show 18 quoted lines
> diff --git a/t/t1360-config-based-hooks.sh b/t/t1360-config-based-hooks.sh > index 4e46d7dd4e..3296d8af45 100755 > --- a/t/t1360-config-based-hooks.sh > +++ b/t/t1360-config-based-hooks.sh > @@ -55,4 +55,15 @@ test_expect_success 'git hook list reorders on duplicate commands' ' > test_cmp expected actual > ' > > +test_expect_success 'git hook list --porcelain prints just the command' ' > + cat >expected <<-\EOF && > + /path/ghi > + /path/abc > + /path/def > + EOF > + > + git hook list --porcelain pre-commit >actual && > + test_cmp expected actual > +'
As you surely found out from the GitHub workflow running in your fork, this does not work on Windows. I need this (and strongly suggest you squash that into your patch):
-- snipsnap -- From 97e3dfa6155785363c881ce2dcaf4f5ddead83ed Mon Sep 17 00:00:00 2001 From: Johannes Schindelin <johannes.schindelin@gmx.de> Date: Mon, 25 May 2020 15:04:24 +0200 Subject: [PATCH] fixup??? hook: add --porcelain to list command
This is required to let the test pass on Windows, where Git reports Windows-style absolute paths and has no idea about the pseudo Unix absolute paths that the Bash knows about.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- t/t1360-config-based-hooks.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t1360-config-based-hooks.sh b/t/t1360-config-based-hooks.sh index c862655fd4d9..fce7335e97b9 100755 --- a/t/t1360-config-based-hooks.sh +++ b/t/t1360-config-based-hooks.sh @@ -65,10 +65,10 @@ test_expect_success 'git hook list reorders on duplicate commands' ' ' test_expect_success 'git hook list --porcelain prints just the command' ' - cat >expected <<-EOF && - $ROOT/path/ghi - $ROOT/path/abc - $ROOT/path/def + cat >expected <<-\EOF && + /path/ghi + /path/abc + /path/def EOF git hook list --porcelain pre-commit >actual && -- 2.27.0.rc1.windows.1