Re: [PATCH] macos: do let the build find the gettext headers/libraries/msgfmt
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 25, 2020, 12:54 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2004251452200.18039@tvgsbejvaqbjf.bet>
- In-Reply-To
- <CAPig+cSkr+2dExzETScru0N5_=JhjVR=QZKuY5CbhstwrUUk5w@mail.gmail.com>
Hi Eric,
On Thu, 23 Apr 2020, Eric Sunshine wrote:
Show 13 quoted lines
> On Thu, Apr 23, 2020 at 12:17 PM Eric Sunshine <sunshine@sunshineco.com> wrote: > > I'm slightly leery of seeing these applied globally on Mac OS in > > config.mak.uname since various package managers on Mac OS install > > packages in wildly different locations, and these settings might cause > > the wrong version of a package to be picked up if a user has a > > preferred version installed elsewhere. > > As a follow up, although slightly leery of applying this change > globally to config.mak.uname, I don't necessarily oppose it either. > Considering how widely adopted Homebrew is on Mac OS, baking in a bit > of Homebrew-specific knowledge would make it easier for a Git > developer to get up and running by eliminating some of the manual > fiddling and configuration currently necessary.
I share your concern. But in contrast to Fink and DarwinPorts, we have no Homebrew-specific knob in the Makefile (does this mean that we expect users to use Homebrew by default?).
With the update that I just sent out, which guards the added flags behind a check for that directory's existence, would you agree that the current state is "good enough"?
Thanks, Dscho