Re: [PATCH v2 3/3] credential: handle `credential.<partial-URL>.<key>` again

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 24, 2020, 00:16 UTC
Message-ID: <nycvar.QRO.7.76.6.2004240215100.18039@tvgsbejvaqbjf.bet>
In-Reply-To: <20200424000558.GB20669@Carlos-MBP>

Hi Carlo,

On Thu, 23 Apr 2020, Carlo Marcelo Arenas Belón wrote:

Show 14 quoted lines

> On Thu, Apr 23, 2020 at 11:43:17PM +0000, Johannes Schindelin via GitGitGadget wrote:
> > diff --git a/credential.c b/credential.c
> > index 52965a5122c..3505f6356d8 100644
> > --- a/credential.c
> > +++ b/credential.c
> > @@ -53,7 +53,13 @@ static int credential_config_callback(const char *var, const char *value,
> >  		char *url = xmemdupz(key, dot - key);
> >  		int matched;
> >
> > -		credential_from_url(&want, url);
> > +		if (credential_from_url_gently(&want, url, 1, 0) < 0) {
>
> definitely not worth a reroll, but just wondering if would make sense to call
> credential_from_url_gently(!quiet) here, just for consistency?

We don't have any `quiet` variable here.

> other than that this series is looking great, under the assumption that there
> is going to be some more followup with non essential changes.

I am sure I don't follow. What non-essential changes are you assuming will follow up?

> will chip in with an test helper for that series so we can hopefully keep our
> sanity next time someone touches that function again.

Are the tests I added to t0300 not enough? Or do you think it will need a native test helper that is included in `t/helper/test-tool` and exercised in the test suite somehow?

Ciao, Dscho