Re: [PATCH v2 2/5] t/lib-gpg.sh: stop pretending to be a stand-alone script
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 26, 2020, 13:48 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2003261446160.46@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20200326082140.GC2200716@coredump.intra.peff.net>
Hi Peff,
On Thu, 26 Mar 2020, Jeff King wrote:
Show 13 quoted lines
> On Wed, Mar 25, 2020 at 05:41:18AM +0000, Johannes Schindelin via GitGitGadget wrote: > > > From: Johannes Schindelin <johannes.schindelin@gmx.de> > > > > It makes no sense to call `./lib-gpg.sh`. Therefore the hash-bang line > > is unnecessary. > > I wondered if it might be useful to identify the file for editors, etc. > But "*.sh" is quite sufficient, and we already stripped most of these > out long ago in b54a31243b (t/lib-*.sh: drop executable bit, > 2020-03-26). > > There's some other related cleanup. I'll prepare a separate series.
I noticed that, but forgot to add a note about this to the commit message. Sorry. The next iteration of this patch series will have that note.
$ git grep '#! */' t/*.sh | grep -v 't[0-9]' t/aggregate-results.sh:#!/bin/sh t/gitweb-lib.sh:#!/usr/bin/perl t/lib-credential.sh:#!/bin/sh
Thank you for volunteering to clean them up!
Ciao, Dscho