Re: [PATCH v4 4/7] remote rename/remove: handle branch.<name>.pushRemote config values

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 26, 2020, 09:30 UTC
Message-ID: <nycvar.QRO.7.76.6.2001261028350.46@tvgsbejvaqbjf.bet>
In-Reply-To: <055e52dd-9349-697c-277f-abc9ac8ae85e@googlemail.com>

Hi Bert,

On Sat, 25 Jan 2020, Bert Wesarg wrote:

Show 42 quoted lines

> On 25.01.20 01:46, Johannes Schindelin wrote:
> > Hi Bert,
> >
> > On Fri, 24 Jan 2020, Bert Wesarg wrote:
> >
> > > When renaming or removing a remote with
> > >
> > >      git remote rename X Y
> > >      git remote remove X
> > >
> > > Git already renames/removes any config values from
> > >
> > >      branch.<name>.remote = X
> > >
> > > to
> > >
> > >      branch.<name>.remote = Y
> > >
> > > As branch.<name>.pushRemote also names a remote, it now also renames
> > > or removes these config values from
> > >
> > >      branch.<name>.pushRemote = X
> > >
> > > to
> > >
> > >      branch.<name>.pushRemote = Y
> > >
> > > Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
> > >
> > > ---
> >
> > This commit seems to cause a failure in t5505:
> > https://dev.azure.com/gitgitgadget/git/_build/results?buildId=27833&view=ms.vss-test-web.build-test-results-tab
> >
> > Here is the excerpt of the log:
> >
> > [...]
> >
> > Could you have a look to see whether the code or the test need to be
> > adjusted?
>
> please ensure that you have v4 of this patch. What you see was a bug in v3.

I was talking about the current state of what was merged into `pu`: https://github.com/gitgitgadget/git/commit/6f032056fd7534b8efd712994c02531d83ada957 (note the red X indicating the build failure).

If you already fixed this, and Junio merely has to pick it up, all the better.

Thanks, Dscho