Re: [PATCH 0/1] Update imap-send.c, fix incompatibilities with OpenSSL 1.1.x

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 7, 2020, 18:48 UTC
Message-ID: <nycvar.QRO.7.76.6.2001071944250.46@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqv9pn5hgl.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Tue, 7 Jan 2020, Junio C Hamano wrote:

Show 23 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > Hi Liam,
> >
> > On Tue, 7 Jan 2020, Liam Huang via GitGitGadget wrote:
> >
> >> Some APIs have been changed since OpenSSL 1.1.0, so fix incompatibilities
> >> with OpenSSL 1.1.x.
> >
> > In your PR, the "Checks" tab shows that this breaks the build for all
> > non-32-bit Linux builds and for Windows. Here is an excerpt of the failed
> > `linux-clang` build:
> > -- snip --
> > ...
> > Could you fix those compile errors, please?
> >
> > While at it, please also fix your author email: it should match your
> > _real_ email address, i.e. "liamhuang0205@gmail.com", not
> > "Liam0205@users.noreply.github.com".
>
> Also, please do *not* CC iterations of a patch to me that hasn't
> seen a concensus that it is a good idea on the list yet, unless
> you know I am the area expert and am interested in seeing it.

I am afraid that I do not know of any means to teach GitGitGadget to make that call whether it has seen a consensus.

And I fear that you are asking me to punt back that decision to contributors, i.e. put a lot of the burden of knowing how Git contributions are expected to progress _away_ from GitGitGadget. It is, however, the explicit mission of GitGitGadget to _take that responsibility of knowing all these things and not err at any step along the way *from* the contributors_.

Of course, I can teach GitGitGadget to not Cc: you. Like, always. Not sure that you would like that any better because you would not even be Cc:ed once consensus was reached. So I'm not sure that I want to put in that work for something you will equally hate in the end.

Or do you have any splendid ideas how this could be made easy on you _and_ on contributors (and for bonus points, _also_ on me)?

Ciao, Dscho