Re: [RFC PATCH 0/4] git-p4: python 3 compatability
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 28, 2019, 12:54 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1911281352130.31080@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20191128012807.3103-1-yang.zhao@skyboxlabs.com>
Hi,
On Wed, 27 Nov 2019, Yang Zhao wrote:
Show 5 quoted lines
> This patchset the necessary changes to have git-p4 run under python 3. > > I'm submitting this as an RFC as the changes are not exhaustive. I do not have > p4d available, and therefore cannot run the tests locally. I have made > best-effort attempts to test the changes against a repo I do have read access to.
How about opening a PR at https://github.com/git/git? This will run our Travis and Azure Pipelines builds, and I am sure that you can add a debug-only patch to force-use Python3 on the Perforce tests (and if I were you, I would also restrict the run to those tests by editing `.travis.yml` and `azure-pipelines.yml`, both of which files should be easy enough to understand without additional documentation).
Ciao, Johannes