Re: [PATCH] t7812: add missing redirects
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 26, 2019, 22:27 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1911262325390.31080@tvgsbejvaqbjf.bet>
- In-Reply-To
- <87blsyl32c.fsf_-_@igel.home>
Hi,
On Tue, 26 Nov 2019, Andreas Schwab wrote:
> Two tests in t7812 were missing redirects, failing to actually test the
> produced output.
>
> Fixes: 8a5999838e ("grep: stess test PCRE v2 on invalid UTF-8 data")Apart from this line which is cuddled with a real footer (but is no footer, and the commit reference is not in the recommended format either because it lacks the date), this patch looks fine to me.
Ciao, Johannes
Show 35 quoted lines
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org> > --- > t/t7812-grep-icase-non-ascii.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/t7812-grep-icase-non-ascii.sh b/t/t7812-grep-icase-non-ascii.sh > index 531eb59d57..c4528432e5 100755 > --- a/t/t7812-grep-icase-non-ascii.sh > +++ b/t/t7812-grep-icase-non-ascii.sh > @@ -70,14 +70,14 @@ test_expect_success GETTEXT_LOCALE,LIBPCRE2 'PCRE v2: grep ASCII from invalid UT > test_expect_success GETTEXT_LOCALE,LIBPCRE2 'PCRE v2: grep non-ASCII from invalid UTF-8 data' ' > git grep -h "æ" invalid-0x80 >actual && > test_cmp expected actual && > - git grep -h "(*NO_JIT)æ" invalid-0x80 && > + git grep -h "(*NO_JIT)æ" invalid-0x80 >actual && > test_cmp expected actual > ' > > test_expect_success GETTEXT_LOCALE,LIBPCRE2 'PCRE v2: grep non-ASCII from invalid UTF-8 data with -i' ' > test_might_fail git grep -hi "Æ" invalid-0x80 >actual && > test_cmp expected actual && > - test_must_fail git grep -hi "(*NO_JIT)Æ" invalid-0x80 && > + test_must_fail git grep -hi "(*NO_JIT)Æ" invalid-0x80 >actual && > test_cmp expected actual > ' > > -- > 2.24.0 > > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different." >