Re: [PATCH 0/8] build-in add -i: implement all commands in the main loop
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 18, 2019, 19:22 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1911181958190.46@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqpnhp3oum.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Mon, 18 Nov 2019, Junio C Hamano wrote:
Show 23 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > > > "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> > > writes: > > > >> Based on the js/builtin-add-i branch, this patch series implements the rest > >> of the commands in git add -i's main loop: update, revert, add_untracked, > >> patch, diff, and quit. Apart from quit, these commands are all very similar > >> in that they first build a list of files, display it, let the user choose > >> which ones to act on, and then perform the action. > > > > So, this obviously depends on the previous "let's start the main > > loop" series, in which I recall you found at least one remaining bug > > after sending the latest round. > > > > I'd prefer to queue this on top of the iteration of that series, > > which would hopefully become the final one, which would let me avoid > > one rebase of this series ;-) > > > > Thanks. > > I found the v7 on the list, which is what I wanted to queue this on > top of. So my wait is over ;-)
Yes, sorry, I did not think that I was opaque but I was.
So to clarify: I will always rebase the built-in add -i/-p patch series on top of what you put on gitster/git. That is, this here patch series will always be rebased on top of js/builtin-add-i, the next patch series will always be rebased on top of js/builtin-add-i-cmds, etc
Ciao, Dscho