Re: [PATCH] doc: improve readability of --rebase-merges in git-rebase
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 11, 2019, 08:49 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1911110948270.46@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20191110095942.GB6071@a.local>
Hi Naveen,
On Sun, 10 Nov 2019, Naveen Nathan wrote:
Show 24 quoted lines
> When --rebase-merges was introduced in 427c3bd28a the sentence > describing the difference between --rebase-merges and --preserve-merges > is a little unclear and difficult to parse. This patch improves readability > while retaining original meaning. > > Signed-off-by: Naveen Nathan <naveen@lastninja.net> > --- > Documentation/git-rebase.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt > index 639a4179d1..6a826b47bd 100644 > --- a/Documentation/git-rebase.txt > +++ b/Documentation/git-rebase.txt > @@ -442,9 +442,9 @@ i.e. commits that would be excluded by linkgit:git-log[1]'s > the `rebase-cousins` mode is turned on, such commits are instead rebased > onto `<upstream>` (or `<onto>`, if specified). > + > -The `--rebase-merges` mode is similar in spirit to the deprecated > -`--preserve-merges`, but in contrast to that option works well in interactive > -rebases: commits can be reordered, inserted and dropped at will. > +The `--rebase-merges` mode is similar in spirit to `--preserve-merges` > +(deprecated) but actually works with interactive rebases, where commits > +can be reordered, inserted and dropped at will.
I like it!
ACK, Dscho
Show 8 quoted lines
> + > It is currently only possible to recreate the merge commits using the > `recursive` merge strategy; Different merge strategies can be used only via > -- > 2.21.0 > > >