Re: [PATCH v2 1/1] fetch: let --jobs=<n> parallelize --multiple, too

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 6, 2019, 09:53 UTC
Message-ID: <nycvar.QRO.7.76.6.1910061151440.46@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqftk67r6j.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Sun, 6 Oct 2019, Junio C Hamano wrote:

Show 24 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > +test_expect_success 'parallel' '
> > +	git remote add one ./bogus1 &&
> > +	git remote add two ./bogus2 &&
> > +
> > +	test_must_fail env GIT_TRACE="$PWD/trace" \
> > +		git fetch --jobs=2 --multiple one two 2>err &&
> > +	grep "preparing to run up to 2 tasks" trace &&
> > +	test_i18ngrep "could not fetch .one.*128" err &&
> > +	test_i18ngrep "could not fetch .two.*128" err
> > +'
> > +
> >  test_done
>
> Thanks.  I think it is much better to prepare these tests like this
> patch does to be broken when phrasing changes---that would give
> feedback and confidence to the person who is changing the message
> and/or the logic to emit the message.
>
> Where does the constant 128 come from, by the way?  If it is from errno.h
> then we will soon hear breakage report from NonStop folks, I predict
> ;-)

It comes from `die()`:

-- snip --
static NORETURN void die_builtin(const char *err, va_list params)
{
        /*
	 * We call this trace2 function first and expect it to va_copy 'params'
	 * before using it (because an 'ap' can only be walked once).
	 */
	trace2_cmd_error_va(err, params);

	vreportf("fatal: ", err, params);

	exit(128);
}
-- snap --

Thanks, Dscho