Re: [PATCH v2] commit-graph: remove a duplicate assignment
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 27, 2019, 12:21 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1909271418170.15067@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20190927021952.364646-1-alexhenrie24@gmail.com>
Hi,
On Thu, 26 Sep 2019, Alex Henrie wrote:
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Hrm, the commit message should reflect Stolee's careful consideration, no? An empty commit message won't be helpful e.g. when cherry-picking on top of a branch that already has your v1.
Ciao, Johannes
Show 21 quoted lines
> ---
> commit-graph.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/commit-graph.c b/commit-graph.c
> index 9b02d2c426..d0e1f9e1f2 100644
> --- a/commit-graph.c
> +++ b/commit-graph.c
> @@ -1522,7 +1522,7 @@ static int write_commit_graph_file(struct write_commit_graph_context *ctx)
>
> static void split_graph_merge_strategy(struct write_commit_graph_context *ctx)
> {
> - struct commit_graph *g = ctx->r->objects->commit_graph;
> + struct commit_graph *g;
> uint32_t num_commits = ctx->commits.nr;
> uint32_t i;
>
> --
> 2.23.0
>
>