git/list[1] front-page[2] threads[3] people[4] search[5] about
 

js/early-config-with-onbranch, was Re: What's cooking in git.git (Aug 2019, #01; Thu, 1)

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 2, 2019, 12:12 UTC
Message-ID
<nycvar.QRO.7.76.6.1908021410540.46@tvgsbejvaqbjf.bet>
In-Reply-To
<20190801214247.GB30522@sigill.intra.peff.net>
Hi Peff,
On Thu, 1 Aug 2019, Jeff King wrote:
Show 17 quoted lines
> On Thu, Aug 01, 2019 at 01:05:12PM -0700, Junio C Hamano wrote:
>
> > * js/early-config-with-onbranch (2019-07-31) 1 commit
> >   (merged to 'next' on 2019-08-01 at 26b713c824)
> >  + config: work around bug with includeif:onbranch and early config
> >
> >  The recently added [includeif "onbranch:branch"] feature does not
> >  work well with an early config mechanism, as it attempts to find
> >  out what branch we are on before we even haven't located the git
> >  repository.  The inclusion during early config scan is ignored to
> >  work around this issue.
> >
> >  Will merge to 'master'.
>
> I had some open comments here on how the "do we have a repo" check is
> done, but I think what is committed here is functionally equivalent. I
> can pursue the NULL the_repository cleanups separately.

Right, I read that as "maybe later" comments, as that project is so different from trying to fix the `onbranch` feature with regards to the early config machinery.

Or did I misread and you want me to do anything about it before v2.23.0?

Ciao, Dscho

Previous: Jeff KingNext: Jeff King
Message 3 of 9 in “What's cooking in git.git (Aug 2019, #01; Thu, 1)”
  1. Junio C HamanoAug 1, 2019
  2. Jeff KingAug 1, 2019
  3. js/early-config-with-onbranch, was Re: What's cooking in git.git (Aug 2019, #01; Thu, 1)Johannes Schindelin, Aug 2, 2019
  4. Jeff KingAug 2, 2019
  5. Junio C HamanoAug 2, 2019
  6. js/visual-studio, was Re: What's cooking in git.git (Aug 2019, #01; Thu, 1)Johannes Schindelin, Aug 2, 2019
  7. Junio C HamanoAug 2, 2019
  8. Johannes SchindelinAug 3, 2019
  9. Junio C HamanoAug 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.