js/early-config-with-onbranch, was Re: What's cooking in git.git (Aug 2019, #01; Thu, 1)
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 2, 2019, 12:12 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1908021410540.46@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20190801214247.GB30522@sigill.intra.peff.net>
Hi Peff,
On Thu, 1 Aug 2019, Jeff King wrote:
Show 17 quoted lines
> On Thu, Aug 01, 2019 at 01:05:12PM -0700, Junio C Hamano wrote: > > > * js/early-config-with-onbranch (2019-07-31) 1 commit > > (merged to 'next' on 2019-08-01 at 26b713c824) > > + config: work around bug with includeif:onbranch and early config > > > > The recently added [includeif "onbranch:branch"] feature does not > > work well with an early config mechanism, as it attempts to find > > out what branch we are on before we even haven't located the git > > repository. The inclusion during early config scan is ignored to > > work around this issue. > > > > Will merge to 'master'. > > I had some open comments here on how the "do we have a repo" check is > done, but I think what is committed here is functionally equivalent. I > can pursue the NULL the_repository cleanups separately.
Right, I read that as "maybe later" comments, as that project is so different from trying to fix the `onbranch` feature with regards to the early config machinery.
Or did I misread and you want me to do anything about it before v2.23.0?
Ciao, Dscho