git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Support for --stdin-paths in commit, add, etc

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 2, 2019, 11:40 UTC
Message-ID
<nycvar.QRO.7.76.6.1908021335250.46@tvgsbejvaqbjf.bet>
In-Reply-To
<f35fe280-2e26-f719-4030-faf261bc9a22@syntevo.com>
Hi Alexandr,
On Thu, 1 Aug 2019, Alexandr Miloslavskiy wrote:
Show 10 quoted lines
> On 01.08.2019 22:45, Junio C Hamano wrote:
> > That does not mean that any patch along that line will automatically
> > be accepted, of course, so the answer to "am I ready to accept"
> > question is a definite no.  No, I am not ready---we will have to
> > look at the actual patches before deciding.
>
> That's why I previously mentioned "good enough" patches :)
>
> Thanks for your time! I guess we'll start with a patch for 'git commit'
> and see how it goes.

From past experience, I find that it is important to also implement the `-z` option (which traditionally means: accept items via the command line that are delimited by NULs).

And you might find inspiration in my patch to read the paths passed to `git reset` from stdin: https://github.com/gitgitgadget/git/pull/133/commits/1db4ef0ec1ec

I guess you could use a similar approach just after the `parse_pathspec()` call in `prepare_index()`: https://github.com/gitgitgadget/git/blob/1db4ef0ec1ec/builtin/commit.c#L339-L342

Ciao, Johannes

Previous: Alexandr MiloslavskiyNext: Alexandr Miloslavskiy
Message 22 of 23 in “Support for --stdin-paths in commit, add, etc”
  1. Alexandr MiloslavskiyJul 31, 2019
  2. Junio C HamanoJul 31, 2019
  3. Jeff KingJul 31, 2019
  4. Junio C HamanoJul 31, 2019
  5. Alexandr MiloslavskiyAug 1, 2019
  6. Phillip WoodAug 1, 2019
  7. Junio C HamanoAug 1, 2019
  8. Alexandr MiloslavskiyAug 1, 2019
  9. Johannes SchindelinAug 2, 2019
  10. Alexandr MiloslavskiyAug 2, 2019
  11. Johannes SchindelinAug 2, 2019
  12. Alexandr MiloslavskiyAug 2, 2019
  13. Alexandr MiloslavskiyAug 2, 2019
  14. Johannes SchindelinAug 2, 2019
  15. Alexandr MiloslavskiyAug 2, 2019
  16. René ScharfeAug 1, 2019
  17. Alexandr MiloslavskiyAug 1, 2019
  18. Junio C HamanoAug 1, 2019
  19. Alexandr MiloslavskiyAug 1, 2019
  20. Junio C HamanoAug 1, 2019
  21. Alexandr MiloslavskiyAug 1, 2019
  22. Johannes SchindelinAug 2, 2019
  23. Alexandr MiloslavskiyAug 2, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.