md/list-objects-filter-combo, was Re: What's cooking in git.git (Jun 2019, #05; Wed, 19)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 21, 2019, 20:06 UTC
Message-ID: <nycvar.QRO.7.76.6.1906212205360.44@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqef3oq3go.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Wed, 19 Jun 2019, Junio C Hamano wrote:

Show 14 quoted lines

> * md/list-objects-filter-combo (2019-06-17) 10 commits
>  - list-objects-filter-options: make parser void
>  - list-objects-filter-options: clean up use of ALLOC_GROW
>  - list-objects-filter-options: allow mult. --filter
>  - strbuf: give URL-encoding API a char predicate fn
>  - list-objects-filter-options: make filter_spec a string_list
>  - list-objects-filter-options: move error check up
>  - list-objects-filter: implement composite filters
>  - list-objects-filter-options: always supply *errbuf
>  - list-objects-filter: put omits set in filter struct
>  - list-objects-filter: make API easier to use
>
>  The list-objects-filter API (used to create a sparse/lazy clone)
>  learned to take a combined filter specification.

This still needs

-- snip -- diff -u -p a/list-objects-filter-options.c b/list-objects-filter-options.c

--- a/list-objects-filter-options.c
+++ b/list-objects-filter-options.c
@@ -146,7 +146,7 @@ static int parse_combine_filter(
 	int result = 0;

 	if (!subspecs[0]) {
-		strbuf_addf(errbuf,
+		strbuf_addstr(errbuf,
 			    _("expected something after combine:"));
 		result = 1;
 		goto cleanup;
--

(see
https://dev.azure.com/gitgitgadget/git/_build/results?buildId=10925&view=logs&jobId=e7b80b24-15e8-561b-2b9b-3069817c0357&taskId=37898c85-3228-5621-0595-22d470949738&lineStart=253&lineEnd=264&colStart=1&colEnd=17)

Ciao,
Dscho