RE: [ANNOUNCE] Git v2.22.0-rc2

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 3, 2019, 13:49 UTC
Message-ID: <nycvar.QRO.7.76.6.1906031544000.48@tvgsbejvaqbjf.bet>
In-Reply-To: <005f01d5194f$5cb08240$161186c0$@nexbridge.com>

Hi Randall,

On Sun, 2 Jun 2019, Randall S. Becker wrote:

Show 11 quoted lines

> Just a few small nits from RC2 test results on the NonStop TNS/E
> platform:
>
> 1. t0021 subtest 15 is being flakey. It fails on the first run (make -k
> test) but succeeds when run in isolation. This is new on the NonStop
> TNS/E platform. t0021 has been a bit flakey in the past, but not
> recently. Just thought I'd mention it. It's only slightly disconcerting
> because I make very heavy use of smudge filters but since it runs fine
> in isolation, I'm going to assume it is fine. We had one unsubstantiated
> report of an occasional misfire of smudge filters, but no substantive
> evidence at this point to reproduce the situation.

t0021.15 is indeed flaky, and not only for NonStop. It is so flaky, even, that I opened https://github.com/gitgitgadget/git/issues/241

> 2. t7519 subtest 25 still does not pass (previously reported for RC1)
> when run via "make -k test" the first time. This runs successfully when
> run in isolation or the second time.

I offered a fix for that in js/fsmonitor-unflake, and it already made it into `next` (and hopefully into v2.22.0) as you can see here: https://github.com/gitgitgadget/git/commit/b5a81697520 (look for the branch symbol below the commit message).

> 3. t9001, t9020, t9600, t9601, t9602, t9604, fail, but should not run on
> platform (not new, just a reminder). We do not have sendmail or
> subversion.

At least for Subversion, this should be detected. For send-email, I don't know... There *was* a bug in t9001 where it failed to mark a send-email tests cases with the `PERL` prerequisite, but that was fixed, and I guess you have Perl anyway?

Ciao, Johannes