git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC] Some #leftoverbits for anyone looking for little projects

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 28, 2019, 18:16 UTC
Message-ID
<nycvar.QRO.7.76.6.1905282014270.44@tvgsbejvaqbjf.bet>
In-Reply-To
<CAHd-oW7BFYd=LQBF4mF5QTpce9YtXj1WDf85AyO+CLwC9GMqDg@mail.gmail.com>
Hi Matheus,
On Tue, 28 May 2019, Matheus Tavares Bernardino wrote:
Show 36 quoted lines
> On Tue, May 28, 2019 at 7:37 AM Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> >
> > On Mon, 20 May 2019, Matheus Tavares wrote:
> >
> > > > Give "rebase -i" some option so when you "reword" the patch is
> > > > included in the message.
> > > >
> > > > I keep going to the shell because I have no idea what change I'm
> > > > describing.
> > >
> > > I have the same problem, so I wanted to try solving this. The patch
> > > bellow creates a "rebase.verboseCommit" configuration that includes a
> > > diff when rewording or squashing. I'd appreciate knowing your thoughts
> > > on it.
> > >
> > > As Christian wisely pointed out to me, though, we can also achieve this
> > > behavior by setting "commit.verbose" to true. The only "downside" of it
> > > is that users cannot choose to see the diff only when rebasing.
> >
> > You could of course add an alias like
> >
> >         [alias]
> >                 myrebase = -c commit.verbose=true rebase
>
> Hmm, I didn't know about `alias`. Thanks for the information.
>
> > which *should* work.
> >
> > However, I am actually slightly in favor of your patch because it *does*
> > make it more convenient to have this on during rebases only.
>
> Another option we were discussing is to document that rebase obeys all
> commit.* options, instead of adding the rebase.verboseCommit config.
> Yes, this way we won't be able to toggle diff for rebase only, but I'm
> not sure if that's something users would want to do...

It is rather unintuitive that the `commit.*` options apply to a rebase. Sure, you could document it. But realistically, how many users will read it? Yes, I agree, that is a very low percentage.

Also: you yourself mentioned the rather convincing use case of `reword`.

Personally, I never really thought that I'd need `commit.verbose`. But your report made me think that I could use it *just* for `reword`, too.

So now you already have two active Git contributors wishing for that feature.

Ciao, Dscho

Previous: Matheus Tavares BernardinoNext: Johannes Schindelin
Message 7 of 13 in “[GSoC] Some #leftoverbits for anyone looking for little projects”
  1. Ævar Arnfjörð BjarmasonMar 17, 2018
  2. Matheus TavaresMay 20, 2019
  3. Ævar Arnfjörð BjarmasonMay 20, 2019
  4. Matheus Tavares BernardinoMay 21, 2019
  5. Johannes SchindelinMay 28, 2019
  6. Matheus Tavares BernardinoMay 28, 2019
  7. Johannes SchindelinMay 28, 2019
  8. Johannes SchindelinMay 29, 2019
  9. Johannes SchindelinMay 29, 2019
  10. Jayati ShrivastavaMar 20, 2022
  11. Christian CouderMar 22, 2022
  12. Ævar Arnfjörð BjarmasonMar 22, 2022
  13. Jayati ShrivastavaMar 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.