Re: [PATCH v3 0/5] Fix and extend encoding handling in fast export/import
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 13, 2019, 10:14 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1905131214260.44@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20190510205335.19968-1-newren@gmail.com>
Hi Elijah,
On Fri, 10 May 2019, Elijah Newren wrote:
Show 10 quoted lines
> * Modified the testcases to pass on Windows[1], as verified via > gitgitgadget pull request[2]. Required adding a couple new files > (which store the desired bytes) and checking the size of the output > instead of checking for particular bytes (but the lengths of the > expected byte sequences differ so this works fine...). > > [1] Failures of previous patchset on Windows noticed and reported by Dscho; > explanation from Hannes is that Windows munges users' command lines to > force them to be characters instead of bytes. > [2] https://github.com/gitgitgadget/git/pull/187
Excellent! Thank you!
Ciao, Dscho