Re: [GSoC] [t9803]

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 18, 2019, 21:07 UTC
Message-ID: <nycvar.QRO.7.76.6.1904182257240.46@tvgsbejvaqbjf.bet>
In-Reply-To: <7BFDFF1D85B3B544BB69BB9AB23D479D01F4534A@arborexcasx3.UTORARBOR.UTORAD.Utoronto.ca>

Hi Julian,

On Wed, 27 Mar 2019, Julian Cheng wrote:

Show 6 quoted lines

> I’m new here and hoping to get to be a part of GSOC 2019. I have questions about the main project and the microproject
>
> Main Project Quesctions
> I was hoping to work on “git revert --drop” and “git commit --reword”.
> Are there any mentors available for this project? The ideas page lists
> mentors for other projects but not this one.

I cannot speak for the available mentors, but I would imagine that all of them have the technical knowledge to mentor this.

> Also, “git revert --drop” and “git commit --reword” appear not to have
> been discussed yet in the public inbox. Is this correct or am I just not
> finding the threads?

I mentioned this idea in https://public-inbox.org/git/alpine.DEB.2.21.1.1710151754070.40514@virtualbox/

Show 6 quoted lines

> Microproject Questions (test_path_is_*)
> I would like to improve t9803-git-p4-shell-metachars.sh
>
> On the microprojects page, it suggests I should run the tests to make
> sure they all pass. But if I’m making changes to the tests, is it really
> adequate testing just to make sure they all pass?

You should of course read the test cases in order to understand what they cover and what they do not cover, and add test cases if there is something important that your patch might affect.

> To run all tests, I assume I would just navigate to the tests folder in
> terminal and call “sh *.sh”, but that doesn’t seem to work.

There is exactly one way how it can work. But there are a million ways how it can fail, so you'll have to be more specific how it "doesn't seem to work".

> Also, when I call “sh  t9803-git-p4-shell-metachars.sh”, I get “error:
> GIT-BUILD-OPTIONS missing (has Git been built?).” Git is definitely
> installed on my computer though. I’ve been using it for months. I cloned
> this repo with Git. What am I missing here?

You have to build it first, by navigating to the top-level directory and calling `make

You have to build it first, by navigating to the top-level directory and calling `make` (I like to use `-j(nproc)` to build in parallel, you might want to use that, too).

Alternatively, you can set `GIT_TEST_INSTALLED` to the absolute path of your `git` executable, but it'd be better to build from the current revision (the installed Git might have different semantics if it is a much older version).

Ciao, Johannes