Re: [PATCH 4/4] get_oid(): when an object was not found, try harder
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 14, 2019, 19:55 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1903142054490.41@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20190314185758.GB26250@sigill.intra.peff.net>
Hi Peff,
On Thu, 14 Mar 2019, Jeff King wrote:
Show 9 quoted lines
> On Thu, Mar 14, 2019 at 02:17:18PM +0100, Johannes Schindelin wrote: > > > > 2. is there a way to cleanly avoid the three-line duplicate? > > [...] > > Peff tried with a function, but I think that this would actually be a > > really appropriate occasion for a well-placed `goto`: > > I worried that a goto would be too confusing/ugly. But I am OK with it > if you are.
I hope that after reading the patch, you will agree with me that it is not too confusing/ugly... ;-)
Ciao, Dscho