Re: [PATCH 1/1] mingw: drop MakeMaker reference

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 25, 2019, 22:07 UTC
Message-ID: <nycvar.QRO.7.76.6.1902252304180.41@tvgsbejvaqbjf.bet>
In-Reply-To: <20190225200225.GA16965@google.com>

Hi Jonathan,

On Mon, 25 Feb 2019, Jonathan Nieder wrote:

Show 16 quoted lines

> Johannes Schindelin via GitGitGadget wrote:
> 
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > In 20d2a30f8ffe (Makefile: replace perl/Makefile.PL with simple make
> > rules, 2017-12-10), Git stopped using MakeMaker. Therefore, that
> > definition in the MINGW-specific section became useless.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >  config.mak.uname | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Yay!
> 
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks!

> Is there a way to automate checking for make variables that are set
> but never used?

No, not that I know of...

The biggest problem is that we only add documentation to the beginning of the Makefile by convention, and there is not really any consistent way to parse that documentation to figure out what build variables are handled currently.

Ciao, Dscho