Re: [PATCH v3 1/1] config: allow giving separate author and committer idents

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 4, 2019, 12:17 UTC
Message-ID: <nycvar.QRO.7.76.6.1902041314160.41@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqfttb599s.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Tue, 29 Jan 2019, Junio C Hamano wrote:

Show 18 quoted lines

> William Hubbs <williamh@gentoo.org> writes:
> 
> > diff --git a/cache.h b/cache.h
> > index 009e8b3b15..375be1f68b 100644
> > --- a/cache.h
> > +++ b/cache.h
> > @@ -1494,10 +1494,19 @@ int date_overflows(timestamp_t date);
> >  #define IDENT_STRICT	       1
> >  #define IDENT_NO_DATE	       2
> >  #define IDENT_NO_NAME	       4
> > +
> > +enum want_ident {
> > +	WANT_BLANK_IDENT,
> > +	WANT_AUTHOR_IDENT,
> > +	WANT_COMMITTER_IDENT,
> 
> I do not recall we crossed the bridge to allow trailing comma here
> at the end of enum definition.

In advice.c:

	enum color_advice {
		ADVICE_COLOR_RESET = 0,
		ADVICE_COLOR_HINT = 1,
	};

In builtin/pack-objects.c:

	enum missing_action {
		MA_ERROR = 0,      /* fail if any missing objects are encountered */
		MA_ALLOW_ANY,      /* silently allow ALL missing objects */
		MA_ALLOW_PROMISOR, /* silently allow all missing PROMISOR objects */
	};

In builtin/rev-list.c:

	enum missing_action {
		MA_ERROR = 0,    /* fail if any missing objects are encountered */
		MA_ALLOW_ANY,    /* silently allow ALL missing objects */
		MA_PRINT,        /* print ALL missing objects in special section */
		MA_ALLOW_PROMISOR, /* silently allow all missing PROMISOR objects */
	};

... and I will stop here. You are correct that the majority of our enums does not let its last item end in a comma. But we did cross that bridge.

Ciao, Dscho