git/list[1] front-page[2] threads[3] people[4] search[5] about
 

pw/rebase-x-sanity-check, was Re: What's cooking in git.git (Jan 2019, #04; Mon, 28)

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 29, 2019, 12:54 UTC
Message-ID
<nycvar.QRO.7.76.6.1901291353340.41@tvgsbejvaqbjf.bet>
In-Reply-To
<xmqq4l9s9zee.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Mon, 28 Jan 2019, Junio C Hamano wrote:
Show 8 quoted lines
> * pw/rebase-x-sanity-check (2019-01-28) 1 commit
>  - rebase -x: sanity check command
> 
>  "git rebase -x $cmd" did not reject multi-line command, even though
>  the command is incapable of handling such a command.  It now is
>  rejected upfront.
> 
>  Will merge to 'next'.

I offered two suggestions: to use a more readable `strchr()` check for the forbidden embedded newlines, and to not bother with special-casing the empty command but instead handling it the exact same way as an invalid command-line would be handled.

Ciao, Dscho

Previous: Torsten BögershausenNext: Junio C Hamano
Message 3 of 11 in “What's cooking in git.git (Jan 2019, #04; Mon, 28)”
  1. Junio C HamanoJan 28, 2019
  2. Torsten BögershausenJan 29, 2019
  3. pw/rebase-x-sanity-check, was Re: What's cooking in git.git (Jan 2019, #04; Mon, 28)Johannes Schindelin, Jan 29, 2019
  4. Junio C HamanoJan 29, 2019
  5. js/rebase-am, was Re: What's cooking in git.git (Jan 2019, #04; Mon, 28)Johannes Schindelin, Jan 29, 2019
  6. tt/bisect-in-c, was Re: What's cooking in git.git (Jan 2019, #04; Mon, 28)Johannes Schindelin, Jan 29, 2019
  7. Johannes SchindelinJan 29, 2019
  8. en/rebase-merge-on-sequencer, was Re: What's cooking in git.git (Jan 2019, #04; Mon, 28)Johannes Schindelin, Jan 29, 2019
  9. Johannes SchindelinJan 29, 2019
  10. ps/stash-in-c, was Re: What's cooking in git.git (Jan 2019, #04; Mon, 28)Johannes Schindelin, Jan 29, 2019
  11. Fix typos in whats-cooking.txt, was Re: What's cooking in git.git (Jan 2019, #04; Mon, 28)Johannes Schindelin, Jan 29, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.