sparse job, was Re: [PATCH] test-xml-encode: fix sparse NULL pointer warnings
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 28, 2019, 16:10 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1901281706440.41@tvgsbejvaqbjf.bet>
- In-Reply-To
- <68a8c70e-dc42-1df3-3616-c096f63cb848@ramsayjones.plus.com>
Hi Ramsay,
On Sat, 26 Jan 2019, Ramsay Jones wrote:
Show 9 quoted lines
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Johannes,
>
> If you need to re-roll your 'js/vsts-ci' branch, could you please
> squash this into the relevant patch (commit af7747e7c7 ("tests: optionally
> write results as JUnit-style .xml", 2019-01-23)).Certainly!
BTW would you be interested in working with me on an Azure Pipeline that runs `sparse` on all of Junio's branches? (I am now pretty proficient with building a software package in one Azure Pipeline, publishing it as a build artifact, then consuming it from another Azure Pipeline, so I would build the `sparse` package as an Ubuntu package and offer it as a build artifact.)
I seem to recall that you once explained to me what it takes, but that mail vanished from my inbox and I cannot find it.
Thanks, Dscho
Show 34 quoted lines
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> t/helper/test-xml-encode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/helper/test-xml-encode.c b/t/helper/test-xml-encode.c
> index 367c4875e6..a648bbd961 100644
> --- a/t/helper/test-xml-encode.c
> +++ b/t/helper/test-xml-encode.c
> @@ -26,7 +26,7 @@ int cmd__xml_encode(int argc, const char **argv)
> if (tmp2) {
> if ((ch & 0xc0) != 0x80) {
> fputs(utf8_replace_character, stdout);
> - tmp2 = 0;
> + tmp2 = NULL;
> cur--;
> continue;
> }
> @@ -34,7 +34,7 @@ int cmd__xml_encode(int argc, const char **argv)
> tmp2++;
> if (--remaining == 0) {
> fwrite(tmp, tmp2 - tmp, 1, stdout);
> - tmp2 = 0;
> + tmp2 = NULL;
> }
> continue;
> }
> --
> 2.20.0
>