Re: [PATCH 1/1] stash: fix segmentation fault when files were added with intent

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 23, 2019, 11:38 UTC
Message-ID: <nycvar.QRO.7.76.6.1901231236060.45@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqd0ooh79n.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Tue, 22 Jan 2019, Junio C Hamano wrote:

Show 12 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > when I want to see whether a given branch is buggy and when I cannot
> > simply `git cherry-pick <commit-demonstrating-a-bug>`:
> >
> > 	git cherry-pick <commit-fixing-the-bug-and-adding-a-test>
> > 	git checkout HEAD^ -- :^/t/
> 
> Yup.  It is easy to just apply the t/ part to grab the test update
> to see breakage (which I already said when I told you to have a fix
> and test protecting the future breakage of the fix in a single patch
> long time ago).

Sorry, that was not my point.

My point is that

	git cherry-pick <commit-fixing-the-bug-and-adding-a-test>
	git checkout HEAD^ -- :^/t/

is *ridiculously* less intuitive than

	git cherry-pick <commit-demonstrating-a-bug>

and I would rather you stop promoting the former over the latter. After all, Git's purpose in life is to make things easier and quicker and less error-prone, rathern than slower, more complicated and unintuitive.

And I am sure you agree with me on that goal, so I do not understand why you promote that a bit more.

Ciao, Dscho