ps/stash-in-c, was Re: What's cooking in git.git (Jan 2019, #02; Tue, 15)

> On 01/15, Junio C Hamano wrote:
> > * ps/stash-in-c (2019-01-04) 27 commits
> >  - tests: add a special setup where stash.useBuiltin is off
> >  - stash: optionally use the scripted version again
> >  - stash: add back the original, scripted `git stash`
> >  - stash: convert `stash--helper.c` into `stash.c`
> >  - stash: replace all `write-tree` child processes with API calls
> >  - stash: optimize `get_untracked_files()` and `check_changes()`
> >  - stash: convert save to builtin
> >  - stash: make push -q quiet
> >  - stash: convert push to builtin
> >  - stash: convert create to builtin
> >  - stash: convert store to builtin
> >  - stash: convert show to builtin
> >  - stash: convert list to builtin
> >  - stash: convert pop to builtin
> >  - stash: convert branch to builtin
> >  - stash: convert drop and clear to builtin
> >  - stash: convert apply to builtin
> >  - stash: mention options in `show` synopsis
> >  - stash: add tests for `git stash show` config
> >  - stash: rename test cases to be more descriptive
> >  - t3903: modernize style
> >  - stash: improve option parsing test coverage
> >  - ident: add the ability to provide a "fallback identity"
> >  - strbuf.c: add `strbuf_insertf()` and `strbuf_vinsertf()`
> >  - strbuf.c: add `strbuf_join_argv()`
> >  - sha1-name.c: add `get_oidf()` which acts like `get_oid()`
> >  - Merge branch 'sd/stash-wo-user-name'
> > 
> >  "git stash" rewritten in C.
> > 
> >  Comments?
> 
> I read over the series last weekend.  I had some small comments on
> 21/26 and 25/26.  I forgot to reply with my overall assessment on the
> thread though.  I'd be happy to give my Reviewed-by for the whole
> series with or without the changes I suggested.  I double-checked the
> re-introduced "legacy" stash script to make sure it is actually the
> same as it is on master.
> 
> So I'd be happy to get this merged into 'next', and if anything comes
> up to fix that on top.