Re: [PATCH 0/1] Be careful about left-over files from git add --edit runs

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 16, 2019, 13:47 UTC
Message-ID: <nycvar.QRO.7.76.6.1901161447150.41@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqef9dsqkh.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Tue, 15 Jan 2019, Junio C Hamano wrote:

Show 7 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
> 
> I didn't realize that "add -e" codepath was so old until today to
> check with "git blame" to see how old this bug was (it predates the
> transition from builtin-foo.c to builtin/foo.c); it seems that it
> was from day one of the feature.

Yes, I introduced that bug right from the start. On the good side: this is *not* an off-by-one bug!

Ciao, Dscho

Show 14 quoted lines

> 
> >
> > Johannes Schindelin (1):
> >   add --edit: truncate the patch file
> >
> >  builtin/add.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >
> > base-commit: ecbdaf0899161c067986e9d9d564586d4b045d62
> > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-107%2Fdscho%2Fadd-e-truncate-v1
> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-107/dscho/add-e-truncate-v1
> > Pull-Request: https://github.com/gitgitgadget/git/pull/107
>