Re: [PATCH 1/1] Add author and committer configuration settings

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 21, 2018, 12:15 UTC
Message-ID: <nycvar.QRO.7.76.6.1812211310040.41@tvgsbejvaqbjf.bet>
In-Reply-To: <20181219183939.16358-2-williamh@gentoo.org>

Hi William,

thank you for putting this together.

On Wed, 19 Dec 2018, William Hubbs wrote:

> -extern const char *fmt_name(const char *name, const char *email);
> +extern const char *fmt_committer_name(void);

If it would not be too much trouble for you, could I ask you to split this change out into a separate commit (which would be the first of now two patches)? It could have a commit message like this:

	ident: rename fmt_name() to fmt_committer_name()

	Ever since 4c28e4ada03f (commit: die before asking to edit the log
	message, 2010-12-20), all remaining callers of that function want
	to format the committer name. To simplify the code, therefore, we
	rename the function and move the getenv() call into it.

Ciao, Dscho