Re: [PATCH v1] mem_pool: add GIT_TRACE_MEMPOOL support
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 28, 2018, 09:37 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1811281036300.41@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20181127195337.3264-1-peartben@gmail.com>
Hi Ben,
On Tue, 27 Nov 2018, Ben Peart wrote:
Show 8 quoted lines
> From: Ben Peart <benpeart@microsoft.com> > > Add tracing around initializing and discarding mempools. In discard report > on the amount of memory unused in the current block to help tune setting > the initial_size. > > Signed-off-by: Ben Peart <benpeart@microsoft.com> > ---
Looks good.
My only question: should we also trace calls to _alloc(), _calloc() and _combine()?
Ciao, Johannes
Show 44 quoted lines
>
> Notes:
> Base Ref: * git-trace-mempool
> Web-Diff: https://github.com/benpeart/git/commit/9ac84bbca2
> Checkout: git fetch https://github.com/benpeart/git git-trace-mempool-v1 && git checkout 9ac84bbca2
>
> mem-pool.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/mem-pool.c b/mem-pool.c
> index a2841a4a9a..065389aaec 100644
> --- a/mem-pool.c
> +++ b/mem-pool.c
> @@ -5,6 +5,7 @@
> #include "cache.h"
> #include "mem-pool.h"
>
> +static struct trace_key trace_mem_pool = TRACE_KEY_INIT(MEMPOOL);
> #define BLOCK_GROWTH_SIZE 1024*1024 - sizeof(struct mp_block);
>
> /*
> @@ -48,12 +49,16 @@ void mem_pool_init(struct mem_pool **mem_pool, size_t initial_size)
> mem_pool_alloc_block(pool, initial_size, NULL);
>
> *mem_pool = pool;
> + trace_printf_key(&trace_mem_pool, "mem_pool (%p): init (%"PRIuMAX") initial size\n",
> + pool, (uintmax_t)initial_size);
> }
>
> void mem_pool_discard(struct mem_pool *mem_pool, int invalidate_memory)
> {
> struct mp_block *block, *block_to_free;
>
> + trace_printf_key(&trace_mem_pool, "mem_pool (%p): discard (%"PRIuMAX") unused\n",
> + mem_pool, (uintmax_t)(mem_pool->mp_block->end - mem_pool->mp_block->next_free));
> block = mem_pool->mp_block;
> while (block)
> {
>
> base-commit: bb75be6cb916297f271c846f2f9caa3daaaec718
> --
> 2.18.0.windows.1
>
>