Re: [PATCH] [Outreachy] git/userdiff.c fix regex pattern error
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 4, 2018, 14:26 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1810041624290.73@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20181004113015.GA30901@manohar-ssh>
Hi Ananya,
thank you for taking the time to write this patch!
On Thu, 4 Oct 2018, Ananya Krishna Maram wrote:
> the forward slash character should be escaped with backslash. Fix > Unescaped forward slash error in Python regex statements. > > Signed-off-by: Ananya Krishna Maram<ananyakittu1997@gmail.com>
That explains pretty well what you did, but I wonder why the forward slash needs to be escaped? I would understand if we enclosed the pattern in `/<regex>/`, as it is done e.g. in Javascript, but we do not...
Thanks, Johannes
Show 21 quoted lines
> ---
> userdiff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/userdiff.c b/userdiff.c
> index f565f6731..f4ff9b9e5 100644
> --- a/userdiff.c
> +++ b/userdiff.c
> @@ -123,7 +123,7 @@ PATTERNS("python", "^[ \t]*((class|def)[ \t].*)$",
> /* -- */
> "[a-zA-Z_][a-zA-Z0-9_]*"
> "|[-+0-9.e]+[jJlL]?|0[xX]?[0-9a-fA-F]+[lL]?"
> - "|[-+*/<>%&^|=!]=|//=?|<<=?|>>=?|\\*\\*=?"),
> + "|[-+*\/<>%&^|=!]=|\/\/=?|<<=?|>>=?|\\*\\*=?"),
> /* -- */
> PATTERNS("ruby", "^[ \t]*((class|module|def)[ \t].*)$",
> /* -- */
> --
> 2.17.1
>
>