git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: range-diff, was Re: What's cooking in git.git (Jul 2018, #03; Wed, 25)

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 1, 2018, 16:01 UTC
Message-ID
<nycvar.QRO.7.76.6.1808011800570.71@tvgsbejvaqbjf.bet>
In-Reply-To
<xmqqwotcivco.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Mon, 30 Jul 2018, Junio C Hamano wrote:
Show 30 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > FWIW I picked up your Asciidoc-underline fix, and I also fixed a typo in a
> > commit message (you may want to pick that up, too, unless you want me to
> > send a full new iteration, I don't care either way):
> 
> Meaning that if you send a full new iteration it would match what we
> have on 'pu' plus the one-liner below?  I think we can do without
> such a resend, because everybody has seen all there is to see if
> that is the case.
> 
> > -- snipsnap --
> > 11:  bf0a5879361 ! 11:  0c1f5db5d01 range-diff: add tests
> >     @@ -3,7 +3,7 @@
> >          range-diff: add tests
> >      
> >          These are essentially lifted from https://github.com/trast/tbdiff, with
> >     -    light touch-ups to account for the command now being names `git
> >     +    light touch-ups to account for the command now being named `git
> >          range-diff`.
> >      
> >          Apart from renaming `tbdiff` to `range-diff`, only one test case needed
> 
> I'll need to remember to rebuild es/format-patch-rangediff after
> amending bf0a587936 with this, but I think I should be able to push
> out the result in today's round.
> 
> If any other issue arises, I do not mind taking an update, either,
> but I think at this point the topic is reaching the point of
> diminishing returns and should switch to incremental.

Thomas had a couple of good suggestions, still, and I am considering to try to find time to simply disable the whitespace warnings altogether in range-diff.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 20 of 25 in “What's cooking in git.git (Jul 2018, #03; Wed, 25)”
  1. Junio C HamanoJul 25, 2018
  2. Stefan BellerJul 25, 2018
  3. Junio C HamanoJul 25, 2018
  4. Junio C HamanoJul 26, 2018
  5. Junio C HamanoJul 26, 2018
  6. Junio C HamanoJul 25, 2018
  7. Junio C HamanoJul 25, 2018
  8. Junio C HamanoJul 26, 2018
  9. Оля ТележнаяJul 26, 2018
  10. Junio C HamanoJul 26, 2018
  11. Christian CouderAug 2, 2018
  12. Junio C HamanoAug 2, 2018
  13. Jeff KingJul 26, 2018
  14. Junio C HamanoJul 26, 2018
  15. Jeff KingJul 26, 2018
  16. Ævar Arnfjörð BjarmasonJul 27, 2018
  17. Junio C HamanoJul 27, 2018
  18. range-diff, was Re: What's cooking in git.git (Jul 2018, #03; Wed, 25)Johannes Schindelin, Jul 30, 2018
  19. Junio C HamanoJul 30, 2018
  20. Johannes SchindelinAug 1, 2018
  21. Junio C HamanoAug 1, 2018
  22. ds/reachable (was Re: What's cooking in git.git (Jul 2018, #03; Wed, 25))Derrick Stolee, Aug 1, 2018
  23. Junio C HamanoAug 1, 2018
  24. ds/multi-pack-index (was Re: What's cooking in git.git (Jul 2018, #03; Wed, 25))Derrick Stolee, Aug 1, 2018
  25. Junio C HamanoAug 1, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.