git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/9] contrib: add a script to initialize VS Code configuration

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 30, 2018, 14:42 UTC
Message-ID
<nycvar.QRO.7.76.6.1807301635020.10478@tvgsbejvaqbjf.bet>
In-Reply-To
<xmqq1sbt68ec.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Mon, 23 Jul 2018, Junio C Hamano wrote:
Show 14 quoted lines
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
> 
> > diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh
> > new file mode 100755
> > index 000000000..3cc93243f
> > --- /dev/null
> > +++ b/contrib/vscode/init.sh
> > @@ -0,0 +1,165 @@
> > +#!/bin/sh
> 
> This is caued by our usual "git apply --whitespace=warn" as it
> contains lines indented by spaces not tabs (perhaps the json
> literals?)
A `git diff --check` does not show any red flag.
> Can we have contrib/vscode/.gitattributes to tweak the whitespace
> breakage checking rules so that this file is excempt?

I would have appreciated quite a bit more clear a message, including how I can trigger this, and what is the appropriate setting.

As it is, I cannot reproduce your problem with a `git show`, so I assume that the main problem is that this commit *does* add that .gitattributes, but of course your `git apply` ran before that file existed.

For your own pleasure, here is the link to the .gitattributes file in the commit that you applied yourself:

https://github.com/gitster/git/commit/44559f0388a4e256bea3eb2f57b92a2b9e3d06f9#diff-046ba41c5a21694c62b8dc5e93d7f0c2R1
I assume that this is good enough for you, and your comment is moot?

Ciao, Dscho

Previous: Junio C HamanoNext: Johannes Schindelin via GitGitGadget
Message 7 of 29 in “Add support to develop Git in Visual Studio Code”
  1. 0/9 Add support to develop Git in Visual Studio CodeJohannes Schindelin via GitGitGadget, Jul 23, 2018
  2. 1/9 contrib: add a script to initialize VS Code configurationJohannes Schindelin via GitGitGadget, Jul 23, 2018
  3. Jonathan NiederJul 23, 2018
  4. Johannes SchindelinJul 30, 2018
  5. Junio C HamanoJul 23, 2018
  6. Junio C HamanoJul 23, 2018
  7. Johannes SchindelinJul 30, 2018
  8. 2/9 vscode: hard-code a couple definesJohannes Schindelin via GitGitGadget, Jul 23, 2018
  9. Jonathan NiederJul 23, 2018
  10. Johannes SchindelinJul 30, 2018
  11. 3/9 cache.h: extract enum declaration from inside a struct declarationJohannes Schindelin via GitGitGadget, Jul 23, 2018
  12. 4/9 mingw: define WIN32 explicitlyJohannes Schindelin via GitGitGadget, Jul 23, 2018
  13. 5/9 vscode: only overwrite C/C++ settingsJohannes Schindelin via GitGitGadget, Jul 23, 2018
  14. 6/9 vscode: wrap commit messages at column 72 by defaultJohannes Schindelin via GitGitGadget, Jul 23, 2018
  15. 8/9 vscode: add a dictionary for cSpellJohannes Schindelin via GitGitGadget, Jul 23, 2018
  16. 9/9 vscode: let cSpell work on commit messages, tooJohannes Schindelin via GitGitGadget, Jul 23, 2018
  17. 7/9 vscode: use 8-space tabs, no trailing ws, etc for Git's source codeJohannes Schindelin via GitGitGadget, Jul 23, 2018
  18. Johannes SixtJul 25, 2018
  19. Johannes SchindelinJul 30, 2018
  20. 0/9 Add support to develop Git in Visual Studio CodeJohannes Schindelin via GitGitGadget, Jul 30, 2018
  21. 2/9 vscode: hard-code a couple definesJohannes Schindelin via GitGitGadget, Jul 30, 2018
  22. 3/9 cache.h: extract enum declaration from inside a struct declarationJohannes Schindelin via GitGitGadget, Jul 30, 2018
  23. 1/9 contrib: add a script to initialize VS Code configurationJohannes Schindelin via GitGitGadget, Jul 30, 2018
  24. 5/9 vscode: only overwrite C/C++ settingsJohannes Schindelin via GitGitGadget, Jul 30, 2018
  25. 6/9 vscode: wrap commit messages at column 72 by defaultJohannes Schindelin via GitGitGadget, Jul 30, 2018
  26. 4/9 mingw: define WIN32 explicitlyJohannes Schindelin via GitGitGadget, Jul 30, 2018
  27. 7/9 vscode: use 8-space tabs, no trailing ws, etc for Git's source codeJohannes Schindelin via GitGitGadget, Jul 30, 2018
  28. 8/9 vscode: add a dictionary for cSpellJohannes Schindelin via GitGitGadget, Jul 30, 2018
  29. 9/9 vscode: let cSpell work on commit messages, tooJohannes Schindelin via GitGitGadget, Jul 30, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.