git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] sequencer: ensure labels that are object IDs are rewritten

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jun 1, 2018, 19:01 UTC
Message-ID
<nycvar.QRO.7.76.6.1806012101370.77@tvgsbejvaqbjf.bet>
In-Reply-To
<20180601174639.875215-1-sandals@crustytoothpaste.net>
Hi Brian,
On Fri, 1 Jun 2018, brian m. carlson wrote:
Show 12 quoted lines
> When writing the todo script for --rebase-merges, we try to find a label
> for certain commits.  If the label ends up being a valid object ID, such
> as when we merge a detached commit, we want to rewrite it so it is no
> longer a valid object ID.
> 
> However, the code path that does this checks for its length to be
> equivalent to GIT_SHA1_RAWSZ, which isn't correct, since what we are
> reading is a hex object ID.  Instead, check for the length being
> equivalent to that of a hex object ID.  Use the_hash_algo so this code
> works regardless of the hash size.
> 
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>

ACK! Dscho

Previous: brian m. carlson
Message 6 of 6 in “sequencer: ensure labels that are object IDs are rewritten”
  1. sequencer: ensure labels that are object IDs are rewrittenbrian m. carlson, May 29, 2018
  2. Johannes SchindelinMay 30, 2018
  3. brian m. carlsonMay 30, 2018
  4. Johannes SchindelinMay 31, 2018
  5. sequencer: ensure labels that are object IDs are rewrittenbrian m. carlson, Jun 1, 2018
  6. Johannes SchindelinJun 1, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.