Re: [PATCH] t9104: kosherly remove remote refs
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 1, 2018, 11:25 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1806011324530.77@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20180601050833.27676-1-chriscool@tuxfamily.org>
Hi Chris,
On Fri, 1 Jun 2018, Christian Couder wrote:
Show 30 quoted lines
> As there are plans to implement other ref storage systems, > let's use a way to remove remote refs that does not depend > on refs being files. > > This makes it clear to readers that this test does not > depend on which ref backend is used. > > Suggested-by: Michael Haggerty <mhagger@alum.mit.edu> > Helped-by: Jeff King <peff@peff.net> > Signed-off-by: Christian Couder <chriscool@tuxfamily.org> > --- > This was suggested and discussed in: > > https://public-inbox.org/git/20180525085906.GA2948@sigill.intra.peff.net/ > > t/t9104-git-svn-follow-parent.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/t/t9104-git-svn-follow-parent.sh b/t/t9104-git-svn-follow-parent.sh > index 9c49b6c1fe..5e0ad19177 100755 > --- a/t/t9104-git-svn-follow-parent.sh > +++ b/t/t9104-git-svn-follow-parent.sh > @@ -215,7 +215,9 @@ test_expect_success "multi-fetch continues to work" " > " > > test_expect_success "multi-fetch works off a 'clean' repository" ' > - rm -rf "$GIT_DIR/svn" "$GIT_DIR/refs/remotes" && > + rm -rf "$GIT_DIR/svn" && > + git for-each-ref --format="option no-deref%0adelete %(refname)" refs/remotes | > + git update-ref --stdin &&
Apart from the line longer than our conventions allow, this looks fine to me!
Show 5 quoted lines
> git reflog expire --all --expire=all && > mkdir "$GIT_DIR/svn" && > git svn multi-fetch > -- > 2.17.0.1035.g12039e008f
Please upgrade ;-)
Ciao, Dscho