Re: [PATCH 0/2] fix a segfault in get_main_ref_store()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 18, 2018, 23:32 UTC
Message-ID: <nycvar.QRO.7.76.6.1805190132170.77@tvgsbejvaqbjf.bet>
In-Reply-To: <20180518222506.GA9527@sigill.intra.peff.net>

Hi Peff,

On Fri, 18 May 2018, Jeff King wrote:

Show 12 quoted lines

> I stumbled across a BUG() today. But interestingly, in the current tip
> of master it actually segfaults instead! This fixes the segfault (back
> into a BUG(), and then fixes the caller to avoid the BUG() in the first
> place).
> 
>   [1/2]: get_main_ref_store: BUG() when outside a repository
>   [2/2]: config: die when --blob is used outside a repository
> 
>  builtin/config.c       | 3 +++
>  refs.c                 | 3 +++
>  t/t1307-config-blob.sh | 4 ++++
>  3 files changed, 10 insertions(+)

Both patches look obviously correct to me.

Thanks, Dscho