git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Troubles with picking an editor during Git update

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 17, 2018, 22:17 UTC
Message-ID
<nycvar.QRO.7.76.6.1805180016210.77@tvgsbejvaqbjf.bet>
In-Reply-To
<CAAdU=LtfkKOKnJJC9yvxG+dZxqUh-Pwa5=ra1DOTfxQSY3e6qg@mail.gmail.com>
Hi Bartosz,
On Thu, 17 May 2018, Bartosz Konikiewicz wrote:
Show 25 quoted lines
> I had an issue with Git installer for Windows while trying to update
> my instance of the software. My previous version was "git version
> 2.15.1.windows.2", while my operating system prompted me to upgrade to
> "2.17.0". The installer asked me to "choose the default editor for
> Git". One of these options was Notepad++ - my editor of choice. Vim
> was selected by default and I've picked Notepad++ from a drop-down
> list. As soon as I did it, a "next" button greyed out. When I moved
> back to the previous step and then forward to the editor choice, the
> "Notepad++" option was still highlighted, and the "next" button wasn't
> greyed out anymore - it was active and I was able to press it and
> continue installation.
> 
> Steps to reproduce:
> 
> 1. Have Notepad++ 6.6.9 installed on Windows 10 64-bit 10.0.17134 Build 17134.
> 2. Use an installer for version 2.17.0 to upgrade from version 2.15.1.
> 3. On an editor selection screen, choose Notepad++ instead of Vim. You
> should be unable to continue installation because of the "next" button
> being disabled.
> 4. Press "prev".
> 5. Press "next". Notepad++ should be still highlighted, and the "next"
> button should be active, allowing to continue installation.
> 
> I find it to be a crafty trick to make me use Vim. I have considered
> it for a good moment.

The code to generate that wizard page is here: https://github.com/git-for-windows/build-extra/blob/5c6f2997acd694f5375722d8d494fb1337abc1fa/installer/install.iss#L1111-L1196

Can you spot anything obvious that could be responsible for the issue you reported? (I can't.)

Ciao, Johannes

Previous: Philip Oakley, CEng MIETNext: Bartosz Konikiewicz
Message 3 of 4 in “Troubles with picking an editor during Git update”
  1. Bartosz KonikiewiczMay 17, 2018
  2. Philip Oakley, CEng MIETMay 17, 2018
  3. Johannes SchindelinMay 17, 2018
  4. Bartosz KonikiewiczMay 18, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.