Re: [PATCH v4] bisect: create 'bisect_flags' parameter in find_bisection()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 20, 2018, 12:23 UTC
Message-ID: <nycvar.QRO.7.76.6.1804201422390.4241@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
In-Reply-To: <20180418210535.1862-1-haraldnordgren@gmail.com>

Hi Harald,

On Wed, 18 Apr 2018, Harald Nordgren wrote:

Show 9 quoted lines

> Make it possible to implement bisecting only on first parents or on
> merge commits by passing flags to find_bisection(), instead of just
> a 'find_all' boolean.
> 
> Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
> ---
> 
> Notes:
>     Use unsigned type and cache flag value

This version looks good to me.

Thanks, Johannes