Re: [PATCH v2 3/4] Add a test to verify that push errors are colorful
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 6, 2018, 12:13 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1804061410100.55@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
- In-Reply-To
- <CAPig+cRL1t78W+58HnN3bFJhZa7b9iu=vQxfAq=rF79p1NgeHw@mail.gmail.com>
Hi Eric,
On Fri, 6 Apr 2018, Eric Sunshine wrote:
Show 21 quoted lines
> On Thu, Apr 5, 2018 at 6:48 PM, Johannes Schindelin > <johannes.schindelin@gmx.de> wrote: > > This actually only tests whether the push errors/hints are colored if > > the respective color.* config settings are `always`, but in the regular > > case they default to `auto` (in which case we color the messages when > > stderr is connected to an interactive terminal), therefore these tests > > should suffice. > > > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > > --- > > diff --git a/t/t5541-http-push-smart.sh b/t/t5541-http-push-smart.sh > > @@ -377,5 +377,23 @@ test_expect_success 'push status output scrubs password' ' > > +test_expect_success 'colorize errors/hints' ' > > + cd "$ROOT_PATH"/test_repo_clone && > > + cat >exp <<-EOF && > > + To http://127.0.0.1:$LIB_HTTPD_PORT/smart/test_repo.git > > + <RED>! [rejected] <RESET> origin/master^ -> master (non-fast-forward) > > + error: failed to push some refs to '\''http://127.0.0.1:$LIB_HTTPD_PORT/smart/test_repo.git'\'' > > + EOF > > This "exp" file is not used by the test.
Indeed! I was *so* sure I had removed it, but a `git stash` must have made that change go away before I could commit it.
Will be fixed in v3.
Ciao, Dscho