Re: [PATCH 3/3] Makefile: optionally symlink libexec/git-core binaries to bin/git
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 15, 2018, 17:05 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1803151804390.64@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
- In-Reply-To
- <CA+55aFwU5fwWx2+DdBp=XCpG2Orx+rA8KxPVtGHxpgHAZs=h2Q@mail.gmail.com>
Hi Linus,
On Wed, 14 Mar 2018, Linus Torvalds wrote:
Show 23 quoted lines
> On Wed, Mar 14, 2018 at 3:14 AM, Ævar Arnfjörð Bjarmason > <avarab@gmail.com> wrote: > > On Wed, Mar 14 2018, Johannes Sixt jotted: > >> > >> It is important to leave the default at hard-linking the binaries, > >> because on Windows symbolic links are second class citizens (they > >> require special privileges and there is a distinction between link > >> targets being files or directories). Hard links work well. > > > > Yeah makes sense. I just want to add this as an option, and think if > > it's proven to be un-buggy we could probably turn it on by default on > > the *nix's if people prefer that, but yeah, we'll definitely need the > > uname detection. > > I definitely would prefer to make symlinks the default on unix. > > It's what we used to do (long long ago), and as you pointed out, it's > a lot clearer what's going on too when you don't have to look at inode > numbers and link counts. > > Forcing hardlinking everywhere by default just because Windows > filesystems suck donkey ass through a straw is not the right thing > either.
The most sensible thing, of course, would be to *not* link the builtins at all. I mean, we deprecated the dashed form (which was a design mistake, whether you admit it or not) a long time ago.
Ciao, Johannes