git-cvs-import retries
- From
- Martin Mares <mj@ucw.cz>
- Date
- Feb 17, 2006, 19:38 UTC
- Message-ID
- <mj+md-20060217.193146.10308.albireo@ucw.cz>
Hello!
I am trying git-cvsimport on a rather huge repository and the CVS server sometimes drops the connection and the whole importing aborts, although it contains some retrying logic. I've noticed that in the connection closes I experience, $res ends up being empty instead of undefined. This is tested by the `server went again' check, but not by the retry check a couple of lines before.
This patch extends the retry check and makes the symptoms go away. However, take it with a grain of salt as I don't understand yet why the connection is aborted.
Have a nice fortnight
--
Martin `MJ' Mares <mj@ucw.cz> http://atrey.karlin.mff.cuni.cz/~mj/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
A jury consists of 12 persons chosen to decide who has the better lawyer.
Signed-Off-By: Martin Mares <mj@ucw.cz>
--- old/git-cvsimport 2006-02-17 13:02:24.000000000 +0100
+++ new/git-cvsimport 2006-02-17 18:13:06.000000000 +0100
@@ -371,7 +371,7 @@
$self->_file($fn,$rev) and $res = $self->_line($fh);
- if (!defined $res) {
+ if (!defined $res || $res eq '') {
# retry
$self->conn();
$self->_file($fn,$rev)