git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] t0001,t1510,t3301: use sane_unset which always returns with status 0

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Jan 6, 2011, 21:39 UTC
Message-ID
<ma1kTwntNDX512DVaUWbBvJaymY_6kS-s_jNuypXDSaVoyGytOK_DA@cipher.nrlssc.navy.mil>
In-Reply-To
<7vlj2xai2v.fsf@alter.siamese.dyndns.org>
On 01/06/2011 02:32 PM, Junio C Hamano wrote:
Show 8 quoted lines
> Thanks; there are a bit more from 
> 
>  $git grep -n -e '^[ 	]*unset[ 	].*&&' t
> 
> * t/t9130-git-svn-authors-file.sh:101:		unset GIT_CONFIG &&
> 
> As far as I can tell, this is unsafe; nobody has set GIT_CONFIG up to this
> point.

Ah, svn isn't installed on the Solaris box I tested on, so this test wasn't run.

-Brandon
Previous: Junio C HamanoNext: Brandon Casey
Message 4 of 5 in “trace.c: ensure NULL is not passed to printf”
  1. 1/3 trace.c: ensure NULL is not passed to printfBrandon Casey, Jan 6, 2011
  2. 2/3 t0001,t1510,t3301: use sane_unset which always returns with status 0Brandon Casey, Jan 6, 2011
  3. Junio C HamanoJan 6, 2011
  4. Brandon CaseyJan 6, 2011
  5. 3/3 t3032: limit sed branch labels to 8 charactersBrandon Casey, Jan 6, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.